[FIX] evaluation: fix operation with empty matrices #7048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
14 tasks
|
@anhe-odoo @rrahir cherrypicking of pull request #6930 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
anhe-odoo
force-pushed
the
saas-18.4-17.0-evaluation-prevent_operation_on_empty_matrixes-anhe-460426-fw
branch
from
7645cb6 to
48910ef
Compare
|
@laa-odoo : Can you have a look at this one before I r+ it ? :) |
anhe-odoo
force-pushed
the
saas-18.4-17.0-evaluation-prevent_operation_on_empty_matrixes-anhe-460426-fw
branch
from
48910ef to
9c88cc3
Compare
Task Description When using empty matrices for math operation (multiplication or inversion), as in the FORECAST formula, we got a traceback and the error message was not clear for the user. This commits aims to fix it by checking that the matrices used in theses operations are not empty and returning an understandable error if it's not the case. Related Task Task: 5001658 X-original-commit: fee8728
anhe-odoo
force-pushed
the
saas-18.4-17.0-evaluation-prevent_operation_on_empty_matrixes-anhe-460426-fw
branch
from
9c88cc3 to
481adf8
Compare
IMO OK |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2025
Task Description When using empty matrices for math operation (multiplication or inversion), as in the FORECAST formula, we got a traceback and the error message was not clear for the user. This commits aims to fix it by checking that the matrices used in theses operations are not empty and returning an understandable error if it's not the case. Related Task closes #7048 Task: 5001658 X-original-commit: fee8728 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Hendrickx Anthony (anhe) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
When using empty matrices for math operation (multiplication or inversion), as in the FORECAST formula, we got a traceback and the error message was not clear for the user. This commits aims to fix it by checking that the matrices used in theses operations are not empty and returning an understandable error if it's not the case.
Related Task
review checklist
Forward-Port-Of: #7042
Forward-Port-Of: #6930