Skip to content

[ADD] util.fields: handle base_import.mapping model/fields renames/removal #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pauloamed
Copy link
Contributor

Implement proper fixing and/or removal of base_import.mapping and records on model/fields renames/removal:

  • renamed fields: update affected base_import.mapping records
  • removed fields: remove affected base_import.mapping records
  • renamed models: update affected base_import.mapping records res_model
  • removed models: remove affected base_import.mapping records

This is a follow-up on 5b944f7

@robodoo
Copy link
Contributor

robodoo commented Jun 25, 2024

Pull request status dashboard

@pauloamed pauloamed requested a review from aj-fuentes June 25, 2024 11:14
Copy link
Contributor

@aj-fuentes aj-fuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not over document the code. It's clear from the code itself, or the commit message, what it does. Comments tend to go out of sync with code later on, and they produce bigger diffs.

@KangOl
Copy link
Contributor

KangOl commented Jun 25, 2024

upgradeci retry with always only base_import+hr

@pauloamed pauloamed force-pushed the master-base_imports-palm branch from ce721bc to 1abdc0a Compare June 25, 2024 14:53
Copy link
Contributor

@aj-fuentes aj-fuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it clearer if the inner function just executes a query without knowing about parameters.

It also makes the inner function relocatable --not a closure.

@pauloamed pauloamed force-pushed the master-base_imports-palm branch from 1abdc0a to c8fd961 Compare June 26, 2024 08:25
@pauloamed pauloamed force-pushed the master-base_imports-palm branch from c8fd961 to 71a2fcc Compare June 26, 2024 08:44
@pauloamed pauloamed force-pushed the master-base_imports-palm branch 2 times, most recently from 003c0d3 to ff3a839 Compare June 26, 2024 12:06
@pauloamed pauloamed force-pushed the master-base_imports-palm branch from ff3a839 to d9b3dfb Compare June 26, 2024 14:32
@pauloamed pauloamed force-pushed the master-base_imports-palm branch 2 times, most recently from 3b02964 to d751f49 Compare June 27, 2024 09:52
@pauloamed pauloamed force-pushed the master-base_imports-palm branch from d751f49 to 371a9e9 Compare July 1, 2024 08:01
…moval

Implement proper fixing and/or removal of base_import.mapping and records on
model/fields renames/removal:
- renamed fields: update affected base_import.mapping records
- removed fields: remove affected base_import.mapping records
- renamed models: update affected base_import.mapping records `res_model`
- removed models: remove affected base_import.mapping records

This is a follow-up on 5b944f7

Co-authored-by: Alvaro Fuentes <[email protected]>
@pauloamed pauloamed force-pushed the master-base_imports-palm branch from 371a9e9 to 36e0a42 Compare July 1, 2024 09:43
Copy link
Contributor

@aj-fuentes aj-fuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KangOl ?

@pauloamed
Copy link
Contributor Author

Pinnglyping @KangOl !

Sorry to be pushy, but we have a client who wants to go live next week and depends on this fix

Copy link
Contributor

@KangOl KangOl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Jul 5, 2024
…moval

Implement proper fixing and/or removal of base_import.mapping and records on
model/fields renames/removal:
- renamed fields: update affected base_import.mapping records
- removed fields: remove affected base_import.mapping records
- renamed models: update affected base_import.mapping records `res_model`
- removed models: remove affected base_import.mapping records

This is a follow-up on 5b944f7

closes #100

Signed-off-by: Christophe Simonis (chs) <[email protected]>
Co-authored-by: Alvaro Fuentes <[email protected]>
robodoo pushed a commit that referenced this pull request Jul 5, 2024
…moval

Implement proper fixing and/or removal of base_import.mapping and records on
model/fields renames/removal:
- renamed fields: update affected base_import.mapping records
- removed fields: remove affected base_import.mapping records
- renamed models: update affected base_import.mapping records `res_model`
- removed models: remove affected base_import.mapping records

This is a follow-up on 5b944f7

closes #100

Signed-off-by: Christophe Simonis (chs) <[email protected]>
Co-authored-by: Alvaro Fuentes <[email protected]>
@robodoo robodoo closed this in 1d9e20e Jul 5, 2024
@robodoo robodoo added the 17.4 label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants