-
Notifications
You must be signed in to change notification settings - Fork 68
[ADD] util.fields: handle base_import.mapping model/fields renames/removal #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not over document the code. It's clear from the code itself, or the commit message, what it does. Comments tend to go out of sync with code later on, and they produce bigger diffs.
upgradeci retry with always only base_import+hr |
ce721bc
to
1abdc0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it clearer if the inner function just executes a query without knowing about parameters.
It also makes the inner function relocatable --not a closure.
1abdc0a
to
c8fd961
Compare
c8fd961
to
71a2fcc
Compare
003c0d3
to
ff3a839
Compare
ff3a839
to
d9b3dfb
Compare
3b02964
to
d751f49
Compare
d751f49
to
371a9e9
Compare
…moval Implement proper fixing and/or removal of base_import.mapping and records on model/fields renames/removal: - renamed fields: update affected base_import.mapping records - removed fields: remove affected base_import.mapping records - renamed models: update affected base_import.mapping records `res_model` - removed models: remove affected base_import.mapping records This is a follow-up on 5b944f7 Co-authored-by: Alvaro Fuentes <[email protected]>
371a9e9
to
36e0a42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KangOl ?
Pinnglyping @KangOl ! Sorry to be pushy, but we have a client who wants to go live next week and depends on this fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
…moval Implement proper fixing and/or removal of base_import.mapping and records on model/fields renames/removal: - renamed fields: update affected base_import.mapping records - removed fields: remove affected base_import.mapping records - renamed models: update affected base_import.mapping records `res_model` - removed models: remove affected base_import.mapping records This is a follow-up on 5b944f7 closes #100 Signed-off-by: Christophe Simonis (chs) <[email protected]> Co-authored-by: Alvaro Fuentes <[email protected]>
…moval Implement proper fixing and/or removal of base_import.mapping and records on model/fields renames/removal: - renamed fields: update affected base_import.mapping records - removed fields: remove affected base_import.mapping records - renamed models: update affected base_import.mapping records `res_model` - removed models: remove affected base_import.mapping records This is a follow-up on 5b944f7 closes #100 Signed-off-by: Christophe Simonis (chs) <[email protected]> Co-authored-by: Alvaro Fuentes <[email protected]>
Implement proper fixing and/or removal of base_import.mapping and records on model/fields renames/removal:
res_model
This is a follow-up on 5b944f7