[RFC][ADD] util/convert_m2o_to_m2m #305
Conversation
|
|
|
@KangOl @aj-fuentes I'd like to receive some early feedback on the design choices before committing further to them. |
Pirols
force-pushed
the
master-convert_m2o_to_m2m-pied
branch
from
c4cc604 to
f1a99cf
Compare
| _validate_model(origin_model) | ||
|
|
||
| if not table_exists(cr, m2m_field): | ||
| raise SleepyDeveloperError("m2m table should already exist warning") |
There was a problem hiding this comment.
IMO this util should create the m2m the table (auto key?).
Still I don't get what you are checking here. Why should there be a table with the name of the m2m_field? Maybe you wanted to check a column?
If we auto-create the m2m table, we will allow simpler code for fields that are introduced as m2o and later changed to m2m in the same major version --think 18.2 and 18.4 for example.
There was a problem hiding this comment.
Yes, you're right. I did not want to duplicate the logic in create_m2m and/or provide the same kind of arguments here. But it is necessary. I guess I can close this in favor of #306
|
In favor of #306 |
TODO