Skip to content

TypeScript house cleaning #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

pschroen
Copy link
Contributor

Finished going through all 46 examples (48 if you include the readme examples), I've made a number of updates, most of which are just consistent spacing and indentation, though there are some updates like the removal of unnecessary return await.

All of the code has been run through prettier and verified to be working. 😉

Process while working on the OGL typings:

  1. Copy-pasted all 48 examples (including readme examples) into my OGL Vanilla TypeScript Template while working on the definitions.
  2. Resolved all build errors and added definitions where needed.
  3. Updated all source files with any discrepancies found.
  4. Copy-pasted all the TypeScript versions of the examples back to the source files, removing the type annotations.
  5. Formatted all files with the OGL prettier config.
  6. Re-tested all the examples.

Next step is cleaning-up my working copy of all the definitions.

Related issue: #24

This was referenced Sep 24, 2023
@gordonnl gordonnl merged commit 6d3cf53 into oframe:master Oct 6, 2023
@gordonnl
Copy link
Contributor

gordonnl commented Oct 6, 2023

Thank you!

@pschroen pschroen deleted the chore/typescript-house-cleaning branch October 6, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants