Skip to content

Don't bless .stderr and .stdout files by default #176

Closed
@xFrednet

Description

@xFrednet

The current default behavior of ui_test::Config::rustc blesses the .stdout and .stderr files. I think it would be better to have the default be non blessing, for two reasons:

  1. To me, this is an unexpected behavior. Seeing cargo test pass, indicated that nothing has changed, while in reality it automatically updated the .stderr files
  2. The CI can pass, even if files were changed.
    ui_test exits with exit code 0, if the .stderr and .stdout files have been updated. In Marker I had a case, where the CI was marked as green because ui_test blessed the files by default and didn't report the mismatch.

I didn't quite know the context of this change, which made blessing the default, but I would recommend changing it back. Both clippy, Marker and I believe rustc support the RUST_BLESS environment flag. If a user wants to always auto-bless, they could set that variable globally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions