Skip to content

Fixes a problem when root is referenced in filter expression (#19) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes a problem when root is referenced in filter expression (#19) #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions jsonpath.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ func (c *Compiled) String() string {
}

func (c *Compiled) Lookup(obj interface{}) (interface{}, error) {
var err error
var (
err error
root = obj
)

for _, s := range c.steps {
// "key", "idx"
switch s.op {
Expand Down Expand Up @@ -128,7 +132,7 @@ func (c *Compiled) Lookup(obj interface{}) (interface{}, error) {
if err != nil {
return nil, err
}
obj, err = get_filtered(obj, obj, s.args.(string))
obj, err = get_filtered(obj, root, s.args.(string))
if err != nil {
return nil, err
}
Expand Down
36 changes: 36 additions & 0 deletions jsonpath_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,47 @@ func Test_jsonpath_JsonPathLookup_filter(t *testing.T) {

res, err = JsonPathLookup(json_data, "$.store.book[?(@.price > 10)]")
t.Log(err, res)
if res_v, ok := res.([]interface{}); !ok {
t.Errorf("expected: []interface{}, received: %v", res)
} else {
if len(res_v) != 2 {
t.Errorf("length of result should be 2, but actual length is %d: %v", len(res_v), res_v)
} else {
prices := []interface{}{res_v[0].(map[string]interface{})["price"], res_v[1].(map[string]interface{})["price"]}
if prices[0] != 12.99 || prices[1] != 22.99 {
t.Errorf("expected book prices: [12.99, 22.99] but received: %v, result: %v", prices, res_v)
}
}
}

res, err = JsonPathLookup(json_data, "$.store.book[?(@.price > $.expensive)].price")
t.Log(err, res)
if res_v, ok := res.([]interface{}); ok != true {
t.Errorf("expected: []interface{}, received: %v", res)
} else {
if len(res_v) != 2 {
t.Errorf("length of result should be 2, but actual length is %d: %v", len(res_v), res_v)
} else {
if res_v[0].(float64) != 12.99 || res_v[1].(float64) != 22.99 {
t.Errorf("expected result: [12.99, 22.99] but received: %v", res_v)
}
}
}

res, err = JsonPathLookup(json_data, "$.store.book[?(@.price < $.expensive)].price")
t.Log(err, res)
if res_v, ok := res.([]interface{}); ok != true {
t.Errorf("expected: []Goods, received: %v", res)
} else {
if len(res_v) != 2 {
t.Errorf("length of result should be 2, but actual length is %d: %v", len(res_v), res_v)
} else {
prices := []float64{res_v[0].(float64), res_v[1].(float64)}
if prices[0] != 8.95 || prices[1] != 8.99 {
t.Errorf("expected result: [8.95, 8.99] but received: %v", prices)
}
}
}
}

func Test_jsonpath_authors_of_all_books(t *testing.T) {
Expand Down