Skip to content

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented Mar 5, 2024

I removed the check that caused a sporadic test failure.
I think we cannot guarantee in the test that all nodes will be touched because some other processes on the system might consume all memory from a particular NUMA node and as a result test is not getting memory allocated from that NUMA node.

@vinser52 vinser52 requested a review from a team as a code owner March 5, 2024 16:10
@igchor
Copy link
Contributor

igchor commented Mar 5, 2024

I think we will want to actually have this check once we have a setup with qemu where we can guarantee proper amount of memory. Could we just put this check under an ifdef for now?

@vinser52
Copy link
Contributor Author

vinser52 commented Mar 5, 2024

I think we will want to actually have this check once we have a setup with qemu where we can guarantee proper amount of memory. Could we just put this check under an ifdef for now?

Sure. do we want to introduce a special macro name now? Do you have ideas?

@vinser52 vinser52 force-pushed the svinogra_fix_test branch from 0c86bb3 to 73331fe Compare March 5, 2024 16:32
@vinser52
Copy link
Contributor Author

vinser52 commented Mar 5, 2024

@igchor I added if def with hardcoded 0 and TODO comments.

@igchor
Copy link
Contributor

igchor commented Mar 5, 2024

I think we will want to actually have this check once we have a setup with qemu where we can guarantee proper amount of memory. Could we just put this check under an ifdef for now?

Sure. do we want to introduce a special macro name now? Do you have ideas?

Maybe something like UMF_TEST_STRICT_NUMA_CHECK? I think we might also use this for things like I described here: #241 (comment)

But we can add this later, I'm still not sure if it would be better to have macro or env variable and control this in runtime. For now, I just don't want to remove the code so we won't forget.

@vinser52 vinser52 force-pushed the svinogra_fix_test branch from 73331fe to 41e7199 Compare March 5, 2024 17:01
@bratpiorka bratpiorka merged commit 40d919c into oneapi-src:main Mar 6, 2024
@vinser52 vinser52 deleted the svinogra_fix_test branch February 4, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants