[Storage] Fix batch remove in ServiceEvents to use the correct batch (BadgerDB, Pebble) #7323
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, instead of using the given batch (transaction), ServiceEvents.BatchRemoveByBlockID() creates a new batch (transaction) and uses the new batch (transaction) to remove service events. This commit fixes ServiceEvents.BatchRemoveByBlockID() by using the given batch to remove service events.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7323 +/- ##
==========================================
- Coverage 41.25% 41.24% -0.01%
==========================================
Files 2193 2193
Lines 192006 192004 -2
==========================================
- Hits 79210 79198 -12
- Misses 106189 106201 +12
+ Partials 6607 6605 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhangchiqing
approved these changes
Apr 18, 2025
peterargue
approved these changes
Apr 24, 2025
fxamacker
deleted the
fxamacker/fix-service-events-remove-not-using-passed-rw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #6527
Currently, instead of using the given batch,
ServiceEvents.BatchRemoveByBlockID()creates a new batch and uses the new batch to remove service events.This PR fixes
ServiceEvents.BatchRemoveByBlockID()by using the given batch to remove service events.I found this while getting familiar with storage code related to BadgerDB and Pebble.