Skip to content

[DataAvailability] Implement oneshot execution data requester #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Apr 22, 2025

Closes #7202

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.10%. Comparing base (0075514) to head (98dfd88).

Files with missing lines Patch % Lines
...tion/requester/oneshot_execution_data_requester.go 96.55% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7329      +/-   ##
==========================================
- Coverage   42.75%   41.10%   -1.66%     
==========================================
  Files        1591     2208     +617     
  Lines      146192   193639   +47447     
==========================================
+ Hits        62507    79588   +17081     
- Misses      78345   107441   +29096     
- Partials     5340     6610    +1270     
Flag Coverage Δ
unittests 41.10% <96.55%> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@illia-malachyn illia-malachyn marked this pull request as ready for review April 25, 2025 12:08
@illia-malachyn illia-malachyn requested a review from a team as a code owner April 25, 2025 12:08
@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented Apr 25, 2025

@peterargue What do you think of this approach? I'm reusing the written code from the previous requester. The test makes sure we download execution data for every block successfully. As the requester's functions are reused, it might be everything we need for now. We can add more tests after integration with the pipeline

@illia-malachyn illia-malachyn changed the title [DataAvailability] add new impl of execution data requester [WIP] [DataAvailability] add new impl of execution data requester Apr 29, 2025
@illia-malachyn illia-malachyn changed the title [DataAvailability] add new impl of execution data requester [DataAvailability] Implement oneshot execution data requester Apr 29, 2025
@Guitarheroua Guitarheroua requested a review from peterargue May 26, 2025 11:44
@Guitarheroua
Copy link
Contributor

@illia-malachyn could you, please, review my changes to your PR

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@peterargue peterargue added this pull request to the merge queue May 29, 2025
Merged via the queue into master with commit b749cb1 May 29, 2025
57 checks passed
@peterargue peterargue deleted the illia-malachyn/7202-add-new-execution-data-requester branch May 29, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataAvailability] Implement Download step logic
4 participants