[DataAvaliability] Add opportunity to extract data from storages #7394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7394 +/- ##
==========================================
+ Coverage 41.05% 42.76% +1.70%
==========================================
Files 2207 1591 -616
Lines 193490 146192 -47298
==========================================
- Hits 79442 62514 -16928
+ Misses 107439 78337 -29102
+ Partials 6609 5341 -1268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
illia-malachyn
commented
May 9, 2025
| @@ -125,3 +125,15 @@ func (t *TransactionResultErrorMessages) Store( | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| // Data returns a copy of all stored transaction result error messages keyed by block ID. | |||
| func (t *TransactionResultErrorMessages) Data() []flow.TransactionResultErrorMessage { | |||
There was a problem hiding this comment.
This is redundant as we use storage for only 1 block. This ByBlockID func can be used instead. Maybe, there's more such functions.
peterargue
reviewed
May 9, 2025
peterargue
approved these changes
May 23, 2025
Guitarheroua
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7378
This PR introduces Data() function that returns a copy of cached data in every storage. Not sure persister will need a copy, but as we use mutexes in the storages, we have to return a copy currently. This can be changed in the future