Support monolog 2.0* #926
Open
Support monolog 2.0* #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjvanmiddelaar
approved these changes
May 19, 2020
|
This is needed for Symfony 5.1 support, please merge it if possible. |
|
@michaelKaefer do you have a solution to install it ? thanks. |
|
@florianfish Yes, but it is private. I just forked it and applied the same changes as in this PR, then released a version of my fork, added the repo of my fork to composer repos and installed my fork. |
|
@michaelKaefer sorry i never did how do you do ? Thanks |
|
@florianfish I already told you what I did, which part is unclear? Also feel free to contact me elsewhere to not spam the people here :) |
|
Can this be merged please? |
|
Hey guys! Please merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR opens the possibility to use the bundle with the last version of SF5 that required monolog 2.X
What I did: