Skip to content

fix: undo color change functionality for elements not working #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kitenite
Copy link

Description

This PR addresses an issue where the undo functionality did not correctly revert color changes on UI elements.

Related Issues

closes onlook-dev#1763

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Fixes undo functionality for color changes by storing and using original styles in HistoryManager.

  • Behavior:
    • Fixes undo functionality for color changes in HistoryManager by storing original styles in originalStyleMap.
    • Updates push() to use original styles when undoing update-style actions.
  • Data Structures:
    • Adds originalStyleMap to HistoryManager to track original styles for update-style actions.
  • Analytics:
    • Modifies sendAnalytics call in push() to use updated action data.

This description was created by Ellipsis for 5312ca0. You can customize this summary. It will automatically update as commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Undo color change does not work for elements (e.g., button)
2 participants