Skip to content

Port Change Bug Fix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Port Change Bug Fix #17

wants to merge 3 commits into from

Conversation

Kitenite
Copy link

Description

This PR is an attempt to fix several bugs related to port change

  • Changing URL in Settings tag does not cause the Window port to change
  • Even after setting a custom port (e.g., 8081), the app continues to load on localhost:3000.

Related Issues and Commits

onlook-dev#1165
onlook-dev#1673
onlook-dev#1571
onlook-dev#1690

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

No Tests Added

Screenshots (if applicable)

demo2.mp4

Additional Notes

There is a slight lag when changes are being applied due to restart of runner.


Important

Fixes port change bugs by updating commands and ensuring correct port usage in index.tsx and create.ts.

  • Behavior:
    • Fixes bug where changing URL in Settings did not update the window port in index.tsx.
    • Ensures app loads on the correct custom port by updating run and build commands in index.tsx and create.ts.
    • Adds onBlur event to restart runner in index.tsx.
  • Commands:
    • Updates run and build commands to use npx next dev -p and npx next build -p with the specified port in index.tsx and create.ts.
  • Misc:
    • Minor refactor to use npx for command execution in create.ts.

This description was created by Ellipsis for 5c9d85a. It will automatically update as commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants