Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an attempt to fix several bugs related to port change
Related Issues and Commits
onlook-dev#1165
onlook-dev#1673
onlook-dev#1571
onlook-dev#1690
Type of Change
Testing
No Tests Added
Screenshots (if applicable)
demo2.mp4
Additional Notes
There is a slight lag when changes are being applied due to restart of runner.
Important
Fixes port change bugs by updating commands and ensuring correct port usage in
index.tsx
andcreate.ts
.Settings
did not update the window port inindex.tsx
.run
andbuild
commands inindex.tsx
andcreate.ts
.onBlur
event to restart runner inindex.tsx
.run
andbuild
commands to usenpx next dev -p
andnpx next build -p
with the specified port inindex.tsx
andcreate.ts
.npx
for command execution increate.ts
.This description was created by
for 5c9d85a. It will automatically update as commits are pushed.