add arg test plus a few minor fixes #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkerzhang
previously requested changes
May 30, 2018
| @@ -18,7 +18,7 @@ def export_nearest(): # type: () -> None | |||
| 'Upsample', | |||
| inputs=['x'], | |||
| outputs=['y'], | |||
| scales=[1.0, 1.0, 2.0, 3.0], | |||
| scales=[2.0, 3.0], | |||
| mode='nearest', | |||
There was a problem hiding this comment.
no. it was discussed and agreed to keep the element number of scales the same as the rank of inputs. In this test case, the input's rank is 4, and we don't want to upsample the 1st and 2nd dimension, so it's 1.0. Make sense?
There was a problem hiding this comment.
As the upsample op now support multiple-D input tensor now (instead of 4-D tensor previously).
fix type annotation, undo upsample change add arg test plus a few minor fixes fix type annotation, undo upsample change Polish the test case
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 5, 2018
) Summary: Pass the end to end test cases in onnx/onnx#1049 Closes #9050 Reviewed By: hlu1 Differential Revision: D8703757 Pulled By: houseroad fbshipit-source-id: 63308202e349dfc02d532e87f49495ba1aab085b
houseroad
approved these changes
Jul 5, 2018
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…torch#9050) Summary: Pass the end to end test cases in onnx/onnx#1049 Closes pytorch#9050 Reviewed By: hlu1 Differential Revision: D8703757 Pulled By: houseroad fbshipit-source-id: 63308202e349dfc02d532e87f49495ba1aab085b
hariharans29
pushed a commit
to hariharans29/onnx
that referenced
this pull request
Aug 15, 2019
* add arg test plus a few minor fixes fix type annotation, undo upsample change add arg test plus a few minor fixes fix type annotation, undo upsample change Polish the test case * Update test cases for ArgMax and ArgMin
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* add arg test plus a few minor fixes fix type annotation, undo upsample change add arg test plus a few minor fixes fix type annotation, undo upsample change Polish the test case * Update test cases for ArgMax and ArgMin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.