-
Notifications
You must be signed in to change notification settings - Fork 443
Bump ONNX 1.14.1 #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ONNX 1.14.1 #2220
Conversation
Signed-off-by: jcwchen <[email protected]>
The only failed test is Error logonnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Load model from /home/vsts/work/1/s/tests/keras2onnx_unit_tests/temp/temp_model_2.onnx failed:/onnxruntime_src/onnxruntime/core/graph/model_load_utils.h:47 void onnxruntime::model_load_utils::ValidateOpsetForDomain(const std::unordered_map, int>&, const onnxruntime::logging::Logger&, bool, const string&, int) ONNX Runtime only *guarantees* support for models stamped with official released onnx opset versions. Opset 18 is under development and support for this is limited. The operator schemas and or other functionality may change before next ONNX release and in this case ONNX Runtime will not guarantee backward compatibility. Current official support for domain ai.onnx is till opset 16. The error only happens in ancient tf-1.15 and I guess tf-1.15 might only work with older version of onnxruntime? I also saw tf-1.15 will be removed in #2216. To confirm, @fatcat-z is this test failure related to ONNX 1.14.1? If not , ONNX 1.14.1 rc2 should be good with tf2onnx. |
No, tf 1.15 will be the only version of tf 1.x to be kept in CI for a long time. That pr aims to check CI failures after upgrade tf, onnx and onnxruntime to latest version. This error has no relationship to onnx 1.14.1 RC2, so you can TF2ONNX as Green. |
I've updated test code as well, now it can pass. |
…cw/verify-onnx-1.14.1
…ensorflow-onnx into jcw/verify-onnx-1.14.1
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
cc @fatcat-z for review. Thanks! |
Bump ONNX 1.14.1 in CIs
Verify ONNX 1.14.1 rc2.Closes #2217.