Fix assignability analysis for prematurely read fields #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errt
reviewed
Jun 9, 2024
...lidate/src/test/java/org/opalj/fpcf/fixtures/xl/js/sandbox/JSAllocationWriteFieldFromJS.java
Outdated
Show resolved
Hide resolved
errt
requested changes
Jul 30, 2024
...cala/org/opalj/tac/fpcf/analyses/fieldassignability/AbstractFieldAssignabilityAnalysis.scala
Outdated
Show resolved
Hide resolved
...cala/org/opalj/tac/fpcf/analyses/fieldassignability/AbstractFieldAssignabilityAnalysis.scala
Outdated
Show resolved
Hide resolved
| } else { | ||
| receiverVar.isDefined && receiverVar.get.definedBy != SelfReferenceParameter | ||
| } | ||
| if (method.isInitializer && method.classFile == field.classFile) { |
There was a problem hiding this comment.
I think this part of the code needs documentation to understand what all of the different conditions do
...main/scala/org/opalj/tac/fpcf/analyses/fieldassignability/L2FieldAssignabilityAnalysis.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/opalj/tac/fpcf/analyses/fieldassignability/L2FieldAssignabilityAnalysis.scala
Outdated
Show resolved
Hide resolved
...utability/openworld/assignability/advanced_counter_examples/PrematurelyReadOfFinalField.java
Outdated
Show resolved
Hide resolved
...utability/openworld/assignability/advanced_counter_examples/PrematurelyReadOfFinalField.java
Outdated
Show resolved
Hide resolved
…m/opalj/opal into fix/assignability-prematurelyRead
…assignments of array values
errt
reviewed
Jan 10, 2025
...main/scala/org/opalj/tac/fpcf/analyses/fieldassignability/L2FieldAssignabilityAnalysis.scala
Outdated
Show resolved
Hide resolved
| if (index > 0 && stmts(index).isPutStatic) { | ||
| stmts(index).asPutStatic.value.asVar | ||
| } else if ( | ||
| index > 0 && stmts(index).isPutField && stmts(index).asPutField.value.asVar.value.isArrayValue.isYes |
There was a problem hiding this comment.
Please document this case, it is unclear why it is like this. In particular, why do we take the value from all PutStatic instructions, but only PutField instructions with array values? And why can't we rely on the receiverVar in all cases? Shouldn't it be same the asPut{Static,Field}.value.asVar anyway?
| if (index > 0 && stmts(index).isPutStatic) { | ||
| stmts(index).asPutStatic.value.asVar | ||
| } else if ( | ||
| index > 0 && stmts(index).isPutField && stmts(index).asPutField.value.asVar.value.isArrayValue.isYes |
There was a problem hiding this comment.
What if it is unknown whether the value is an array value? (Not sure if this can happen here, but still, one should think about it)
| } else { | ||
| receiverVar.isDefined && receiverVar.get.definedBy != SelfReferenceParameter | ||
| } | ||
| if (method.isInitializer && method.classFile == field.classFile) { |
maximilianruesch
changed the title
# Conflicts: # OPAL/tac/src/main/scala/org/opalj/tac/fpcf/analyses/fieldassignability/L2FieldAssignabilityAnalysis.scala
# Conflicts: # OPAL/tac/src/main/scala/org/opalj/tac/fpcf/analyses/fieldassignability/AbstractFieldAssignabilityAnalysis.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FieldAssignabilityAnalysistries to determine whether one can consider a field as "final", i.e. if only one known value exists for this field. This can be the case even when the field is not itself final, i.e. when there is a singular write in the constructor that publishes a single value.However, one can read the field before this singular write in the constructor, yielding the default value of the field (whether explicitly given or not). Thus, two known values of this field exist, and we cannot simply consider the field as having one value anymore.
We need to think about this some more!