Improve DocSum file handling #1562
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
|
Marking as draft, until also manually tested. |
eero-t
force-pushed
the
docsum-file-handling
branch
from
f391548 to
1cf483c
Compare
eero-t
force-pushed
the
docsum-file-handling
branch
from
1cf483c to
02628dc
Compare
eero-t
force-pushed
the
docsum-file-handling
branch
from
02628dc to
db0dfd5
Compare
eero-t
force-pushed
the
docsum-file-handling
branch
from
db0dfd5 to
b59c9df
Compare
|
@vrantala Rebased to |
eero-t
force-pushed
the
docsum-file-handling
branch
from
b59c9df to
7280787
Compare
Use temporary file only when necessary, and use aiofiles own functionality for that. Signed-off-by: Eero Tamminen <[email protected]>
eero-t
force-pushed
the
docsum-file-handling
branch
from
7280787 to
83b034a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use temporary file only when necessary, and use
aiofilesown functionality for that.Issues
n/a.Type of change
Dependencies
n/a.Tests
Just CI so far, so this is marked as draft.