Skip to content

Refine README.MD for MultimodalQnA on AMD ROCm platform #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Refine README.MD for MultimodalQnA on AMD ROCm platform #1898

wants to merge 19 commits into from

Conversation

artem-astafev
Copy link
Contributor

@artem-astafev artem-astafev commented Apr 30, 2025 •
edited
Loading

Description

Refine readme of MultimodalQnA for AMD ROCm docker compose deployment

Issues

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

None

@artem-astafev
Refine Readme for multimodalQnA
a2775a3 
Signed-off-by: Artem Astafev <[email protected]>
@artem-astafev
Delete .README.md.kate-swp
5845771 
Signed-off-by: Artem Astafev <[email protected]>
@artem-astafev
Delete README_old.md
5ede8b1 
Signed-off-by: Artem Astafev <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

lvliang-intel
lvliang-intel reviewed May 5, 2025
View reviewed changes
@yinghu5 yinghu5 requested a review from Copilot May 6, 2025 05:22
Copilot
Copilot AI reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • MultimodalQnA/docker_compose/amd/gpu/rocm/set_env_vllm.sh: Language not supported

@yinghu5 yinghu5 requested a review from mkbhanda May 6, 2025 05:22
@yinghu5 yinghu5 requested a review from vikramts May 20, 2025 02:06
Spycsh
Spycsh reviewed May 20, 2025
View reviewed changes
ashahba
ashahba requested changes May 20, 2025
View reviewed changes
vikramts
vikramts reviewed May 20, 2025
View reviewed changes
Copy link
Collaborator

@vikramts vikramts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments to the new additions.

artem-astafev and others added 9 commits May 26, 2025 15:09
@artem-astafev
Merge branch 'main' into feature/multimodal-redefine-readme-for-rocm
a27dac0
@artem-astafev
Update README.md
793f5ca 
Signed-off-by: Artem Astafev <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7e9da1c 
for more information, see https://pre-commit.ci
@artem-astafev
Update README.md
7261d31 
Signed-off-by: Artem Astafev <[email protected]>
@artem-astafev
Merge branch 'feature/multimodal-redefine-readme-for-rocm' of https:/…
a16c6c4 
…/github.com/artem-astafev/GenAIExamples into feature/multimodal-redefine-readme-for-rocm
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b0ce48f 
for more information, see https://pre-commit.ci
@artem-astafev
Merge branch 'main' into feature/multimodal-redefine-readme-for-rocm
53b1bf7
@artem-astafev
Merge branch 'main' into feature/multimodal-redefine-readme-for-rocm
312b143
@ZePan110
Merge branch 'main' into feature/multimodal-redefine-readme-for-rocm
559288e
@xiguiw
Copy link
Collaborator

xiguiw commented Jun 11, 2025 •
edited
Loading

@artem-astafev

  1. please confirm "Resolve conversation" for each comment if they were resolved.
  2. Please help to resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramts vikramts vikramts left review comments

@Spycsh Spycsh Spycsh left review comments

Copilot code review Copilot Copilot left review comments

@ashahba ashahba ashahba requested changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@mkbhanda mkbhanda Awaiting requested review from mkbhanda

@mhbuehler mhbuehler Awaiting requested review from mhbuehler mhbuehler is a code owner

@tileintel tileintel Awaiting requested review from tileintel tileintel is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@artem-astafev @xiguiw @ashahba @vikramts @Spycsh @lvliang-intel @yinghu5 @ZePan110