Skip to content

AgentQnA - add support for remote server #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2025

Conversation

alexsin368
Copy link
Collaborator

@alexsin368 alexsin368 commented May 2, 2025

Description

Add support for usage of a remote server inference endpoint. Supports Enterprise Inference.
Clean up README with fixed typos and additional instructions for setting up the OpenAI endpoint on the WebUI server.

Related dependent PR: opea-project/GenAIComps#1644

Issues

N/A

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Tested AgentQnA on the UI and verified the chat completions are working.

Copy link

github-actions bot commented May 2, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Collaborator

@louie-tsai louie-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just create a yaml file to overwrite original compose.yaml instead of creating a new one? it increase a maintenance efforts, and you probably just change couple values for vllm. please check compose.telemetry.yaml as an example.

if all new features create a new compose.yaml, we will be overwhelmed with many compose.yaml files soon.

Copy link
Collaborator Author

@alexsin368 alexsin368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed comments

@alexsin368
Copy link
Collaborator Author

The hyperlink check is failing with https://platform.openai.com/api-keys. I checked that it is a valid link, just requires the user to log in to their OpenAI account. Can we bypass this error?

@yinghu5 yinghu5 requested review from yinghu5 and Copilot May 7, 2025 08:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A pull request to add support for remote server inference, including configuration updates and documentation enhancements.

  • Introduces a new docker-compose file with environment variables for remote inference.
  • Updates the README with corrected typos and detailed instructions for setting up both OpenAI and remote server inference.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
AgentQnA/docker_compose/intel/cpu/xeon/compose_remote.yaml New configuration file for setting environment variables for remote inference.
AgentQnA/README.md Updated documentation with instructions for configuring remote inference and fixes.
Comments suppressed due to low confidence (1)

AgentQnA/README.md:225

  • [nitpick] The variable name 'model' is generic and may lead to confusion; consider renaming it to something more descriptive, such as MODEL_ID, to clearly indicate its purpose.
export model=<name-of-model-card>

@yinghu5
Copy link
Collaborator

yinghu5 commented May 7, 2025

Hi @vikramts @NeoZhangJianyu Here the Hyperlink check CI report error, could you please help to resolve it?

@vikramts
Copy link
Collaborator

vikramts commented May 8, 2025

@alexsin368 - If the https://platform.openai.com/api-keys URL is valid, then I don't see why we cannot bypass the error detail. Technically, this is not an error. And we can expect the user to understand that they need to log into their OpenAI account. So I do not see an error here really.

@alexsin368 alexsin368 requested a review from ashahba as a code owner May 13, 2025 17:42
Copy link
Collaborator

@louie-tsai louie-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks

Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yinghu5 yinghu5 merged commit fb53c53 into opea-project:main May 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants