-
Notifications
You must be signed in to change notification settings - Fork 295
Fix string comparison in HybridRAG test script #2004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Abolfazl Shahbazi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- HybridRAG/tests/test_compose_on_gaudi.sh: Language not supported
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but this is Bash specific syntax. Shell string comparison operator is =
in the POSIX standard (which is naturally accepted also by Bash): https://stackoverflow.com/questions/1089813/bash-dash-and-string-comparison
Signed-off-by: Abolfazl Shahbazi <[email protected]>
Signed-off-by: Abolfazl Shahbazi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thank you!
Description
There are multiple string comparisons in
HybridRAG/tests/test_compose_on_gaudi.sh
that use-eq
which is meant to be used for numerical comparisons.Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
The test script itself should remain working.