Skip to content

FinanceAgent - enable on Xeon, remote endpoint, and refactor tests #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexsin368
Copy link
Collaborator

Description

  • Enable support for running OpenAI models on Xeon
  • Enable remote endpoints for the LLMs on the agents only (docsum and dataprep will still run LLM locally)
  • Reorganize set_env.sh environment variables
  • Refactor tests: since Xeon test steps are similar to Gaudi's, breaking out the tests to make it easier to add new test steps or new tests for hardware

Issues

#1973

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Added new test script.
Verified FinanceAgent is running on the UI.

Copy link

github-actions bot commented Jun 4, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@Copilot Copilot AI review requested due to automatic review settings August 5, 2025 22:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enables FinanceAgent support for Intel® Xeon® processors with OpenAI models and remote endpoints, while reorganizing the test structure for better maintainability across hardware platforms.

  • Adds Xeon support with OpenAI model integration and remote endpoint configuration
  • Refactors test scripts into modular step-based components for reusability
  • Reorganizes environment variables and documentation for clearer configuration

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
test_compose_on_gaudi.sh Refactored to use modular step scripts instead of inline functions
step*.sh New modular test step scripts extracted from original Gaudi test
_test_compose_openai_on_xeon.sh New test script for Xeon platform using OpenAI models
set_env.sh (gaudi/xeon) Environment configuration files with proper variable validation
compose_*.yaml (xeon) Docker compose files for Xeon deployment with OpenAI and remote endpoints
README.md files Updated documentation for Xeon support and corrected typos

Copy link
Collaborator Author

@alexsin368 alexsin368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed all comments

@alexsin368
Copy link
Collaborator Author

@letonghan @XinyuYe-Intel may I get your review on this PR before the code freeze this Friday?

@joshuayao joshuayao added the feature New feature or request label Aug 13, 2025
@joshuayao joshuayao added this to OPEA Aug 13, 2025
@joshuayao joshuayao removed the feature New feature or request label Aug 13, 2025
@joshuayao joshuayao moved this to In review in OPEA Aug 13, 2025
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsin368 alexsin368 requested a review from amberjain1 August 13, 2025 19:44
@joshuayao joshuayao removed this from the v1.4 milestone Aug 14, 2025
Copy link
Collaborator Author

@alexsin368 alexsin368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed Louie's comments

@louie-tsai
Copy link
Collaborator

@alexsin368 please update/rebase your branch

@alexsin368 alexsin368 merged commit 00b019c into opea-project:main Aug 15, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Aug 15, 2025
@alexsin368 alexsin368 deleted the finance-agent-remote-endpoint-new branch August 18, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants