-
Notifications
You must be signed in to change notification settings - Fork 308
FinanceAgent - enable on Xeon, remote endpoint, and refactor tests #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FinanceAgent - enable on Xeon, remote endpoint, and refactor tests #2032
Conversation
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
for more information, see https://pre-commit.ci
Signed-off-by: alexsin368 <[email protected]>
…m/alexsin368/GenAIExamples into finance-agent-remote-endpoint-new
…m/alexsin368/GenAIExamples into finance-agent-remote-endpoint-new
Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enables FinanceAgent support for Intel® Xeon® processors with OpenAI models and remote endpoints, while reorganizing the test structure for better maintainability across hardware platforms.
- Adds Xeon support with OpenAI model integration and remote endpoint configuration
- Refactors test scripts into modular step-based components for reusability
- Reorganizes environment variables and documentation for clearer configuration
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
test_compose_on_gaudi.sh | Refactored to use modular step scripts instead of inline functions |
step*.sh | New modular test step scripts extracted from original Gaudi test |
_test_compose_openai_on_xeon.sh | New test script for Xeon platform using OpenAI models |
set_env.sh (gaudi/xeon) | Environment configuration files with proper variable validation |
compose_*.yaml (xeon) | Docker compose files for Xeon deployment with OpenAI and remote endpoints |
README.md files | Updated documentation for Xeon support and corrected typos |
Signed-off-by: alexsin368 <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed all comments
@letonghan @XinyuYe-Intel may I get your review on this PR before the code freeze this Friday? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed Louie's comments
@alexsin368 please update/rebase your branch |
Description
Issues
#1973
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Added new test script.
Verified FinanceAgent is running on the UI.