-
Notifications
You must be signed in to change notification settings - Fork 295
Change HUGGINGFACEHUB_API_TOKEN to HF_TOKEN for DocSum,DocIndexRetriever,DBQnA,CodeTrans,CodeGen #2094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the naming of the environment variable from HUGGINGFACEHUB_API_TOKEN to HF_TOKEN across multiple docker compose and configuration files for services including AgentQnA, DocSum, DocIndexRetriever, DBQnA, CodeTrans, and CodeGen.
- Replaces HUGGINGFACEHUB_API_TOKEN with HF_TOKEN in YAML and shell configuration files.
- Ensures consistent token naming across various hardware setups (Intel, AMD) and deployment configurations.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
DocSum/docker_compose/intel/hpu/gaudi/compose_tgi.yaml | Updated token variable naming for consistency. |
DocSum/docker_compose/intel/hpu/gaudi/compose.yaml | Updated token variable naming for consistency. |
DocSum/docker_compose/intel/cpu/xeon/compose_tgi.yaml | Updated token variable naming for consistency. |
DocSum/docker_compose/intel/cpu/xeon/compose.yaml | Updated token variable naming for consistency. |
DocSum/docker_compose/amd/gpu/rocm/compose_vllm.yaml | Updated token variable naming for consistency. |
DocSum/docker_compose/amd/gpu/rocm/compose.yaml | Updated token variable naming for consistency. |
DocIndexRetriever/docker_compose/intel/hpu/gaudi/compose_milvus.yaml | Updated token variable naming for consistency. |
DocIndexRetriever/docker_compose/intel/hpu/gaudi/compose.yaml | Updated token variable naming for consistency. |
DocIndexRetriever/docker_compose/intel/cpu/xeon/compose_without_rerank.yaml | Updated token variable naming for consistency. |
DocIndexRetriever/docker_compose/intel/cpu/xeon/compose_milvus.yaml | Updated token variable naming for consistency. |
DocIndexRetriever/docker_compose/intel/cpu/xeon/compose.yaml | Updated token variable naming for consistency. |
DBQnA/docker_compose/intel/cpu/xeon/set_env.sh | Removed HUGGINGFACEHUB_API_TOKEN; now using HF_TOKEN. |
DBQnA/docker_compose/intel/cpu/xeon/compose.yaml | Updated token variable naming for consistency. |
DBQnA/docker_compose/amd/gpu/rocm/compose.yaml | Updated token variable naming; note presence of HUGGING_FACE_HUB_TOKEN. |
CodeTrans/docker_compose/intel/hpu/gaudi/compose_tgi.yaml | Updated token variable naming for consistency. |
CodeTrans/docker_compose/intel/cpu/xeon/compose_tgi.yaml | Updated token variable naming for consistency. |
CodeTrans/docker_compose/amd/gpu/rocm/compose_vllm.yaml | Updated token variable naming for consistency. |
CodeTrans/docker_compose/amd/gpu/rocm/compose.yaml | Updated token variable naming for consistency. |
CodeGen/docker_compose/intel/hpu/gaudi/compose_tgi.yaml | Updated token variable naming for consistency. |
CodeGen/docker_compose/intel/hpu/gaudi/compose.yaml | Updated token variable naming for consistency. |
CodeGen/docker_compose/intel/cpu/xeon/compose_tgi.yaml | Updated token variable naming for consistency. |
CodeGen/docker_compose/intel/cpu/xeon/compose_remote.yaml | Updated token variable naming for consistency. |
CodeGen/docker_compose/intel/cpu/xeon/compose.yaml | Updated token variable naming for consistency. |
CodeGen/docker_compose/amd/gpu/rocm/compose_vllm.yaml | Updated token variable naming for consistency. |
CodeGen/docker_compose/amd/gpu/rocm/compose.yaml | Updated token variable naming for consistency. |
AgentQnA/docker_compose/intel/hpu/gaudi/compose.yaml | Updated token variable naming for consistency. |
AgentQnA/docker_compose/amd/gpu/rocm/compose_vllm.yaml | Updated token variable naming for consistency. |
AgentQnA/docker_compose/amd/gpu/rocm/compose.yaml | Updated token variable naming for consistency; see note below. |
Comments suppressed due to low confidence (2)
AgentQnA/docker_compose/amd/gpu/rocm/compose.yaml:16
- Review if 'HUGGING_FACE_HUB_TOKEN' should also be renamed or consolidated to 'HF_TOKEN' to ensure consistent naming across all configuration files.
HUGGING_FACE_HUB_TOKEN: ${HF_TOKEN}
DBQnA/docker_compose/amd/gpu/rocm/compose.yaml:22
- Consider whether 'HUGGING_FACE_HUB_TOKEN' should be updated to follow the new 'HF_TOKEN' naming convention to maintain consistency with this PR's changes.
HUGGING_FACE_HUB_TOKEN: ${DBQNA_HUGGINGFACEHUB_API_TOKEN}
…ver,DBQnA,CodeTrans,CodeGen Signed-off-by: ZePan110 <[email protected]>
Description
Change HUGGINGFACEHUB_API_TOKEN to HF_TOKEN for DocSum,DocIndexRetriever,DBQnA,CodeTrans,CodeGen
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.