Skip to content

Homogeneous freezing #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Conversation

tluettm
Copy link
Collaborator

@tluettm tluettm commented Jan 4, 2025

Added homogeneous freezing routines as an optional freezing mode in the freezing dynamic

@tluettm tluettm requested a review from slayoo May 16, 2025 12:55
@tluettm
Copy link
Collaborator Author

tluettm commented May 16, 2025

I can't figure out what pdoc wants changed. As for pylint complaints - I don't see what other examples do differently. They also don't call super().init

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (f4931b6) to head (4593b99).

Files with missing lines Patch % Lines
...ics/homogeneous_ice_nucleation_rate/koop_murray.py 57.14% 3 Missing ⚠️
...DM/physics/homogeneous_ice_nucleation_rate/koop.py 66.66% 2 Missing ⚠️
...hysics/homogeneous_ice_nucleation_rate/constant.py 85.71% 1 Missing ⚠️
...ysics/homogeneous_ice_nucleation_rate/koop_corr.py 83.33% 1 Missing ⚠️
...DM/physics/homogeneous_ice_nucleation_rate/null.py 83.33% 1 Missing ⚠️
PySDM/physics/trivia.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
+ Coverage   85.49%   85.52%   +0.03%     
==========================================
  Files         393      399       +6     
  Lines        9571     9654      +83     
==========================================
+ Hits         8183     8257      +74     
- Misses       1388     1397       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants