Skip to content

Conversation

james-milligan
Copy link
Contributor

This PR

  • renames package kube-flagd-proxy to flagd-proxy
  • updates all references of kube-flagd-proxy to flagd-proxy

Related Issues

open-feature/open-feature-operator#412 (comment)

Notes

Follow-up Tasks

How to test

Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan requested a review from a team March 30, 2023 10:20
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #576 (019be18) into main (bed9458) will not change coverage.
The diff coverage is n/a.

❗ Current head 019be18 differs from pull request most recent head 72903bf. Consider uploading reports for the commit 72903bf to get more accurate results

@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files          21       21           
  Lines        2162     2162           
=======================================
  Hits         1531     1531           
  Misses        574      574           
  Partials       57       57           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -1,13 +1,13 @@
# Changelog

## [0.1.2](https://github.com/open-feature/flagd/compare/kube-flagd-proxy/v0.1.1...kube-flagd-proxy/v0.1.2) (2023-03-20)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the link 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, we could start a fresh changelog for the flagd proxy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be the best 👍 We could combine the previous entries at the bottom of the new changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive cleared the changelog, and tested that this does not break the action

Signed-off-by: James Milligan <[email protected]>
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... I guess since nothing (except your OFO PR) is using this yet, this won't break anything for anyone.

@james-milligan james-milligan changed the title feat!: proposal - rename kube-flagd-proxy to flagd-proxy feat!: rename kube-flagd-proxy to flagd-proxy Mar 30, 2023
@toddbaert toddbaert merged commit 223de99 into open-feature:main Mar 30, 2023
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
toddbaert added a commit that referenced this pull request Mar 30, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.5.0</summary>

##
[0.5.0](flagd/v0.4.5...flagd/v0.5.0)
(2023-03-30)


### ⚠ BREAKING CHANGES

* unify sources configuration handling
([#560](#560))

### 🐛 Bug Fixes

* benchmark pipeline
([#538](#538))
([62cc0fc](62cc0fc))
* **deps:** update module github.com/open-feature/flagd/core to v0.4.5
([#552](#552))
([41799f6](41799f6))


### 🧹 Chore

* refactor configuration handling for startup
([#551](#551))
([8dfbde5](8dfbde5))
</details>

<details><summary>flagd-proxy: 0.2.0</summary>

##
[0.2.0](flagd-proxy-v0.1.2...flagd-proxy/v0.2.0)
(2023-03-30)


### ⚠ BREAKING CHANGES

* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))

### ✨ New Features

* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))
([223de99](223de99))
</details>

<details><summary>core: 0.5.0</summary>

##
[0.5.0](core/v0.4.5...core/v0.5.0)
(2023-03-30)


### ⚠ BREAKING CHANGES

* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))
* unify sources configuration handling
([#560](#560))

### 🧹 Chore

* move credential builder for grpc sync into seperate component
([#536](#536))
([7314fee](7314fee))
* refactor configuration handling for startup
([#551](#551))
([8dfbde5](8dfbde5))
* refactor middleware setup in server
([#554](#554))
([01016c7](01016c7))
* refactor service configuration objects
([#545](#545))
([c7b29ed](c7b29ed)),
closes [#524](#524)
* unify sources configuration handling
([#560](#560))
([7f4888a](7f4888a))


### 🐛 Bug Fixes

* **deps:** update module google.golang.org/grpc to v1.54.0
([#548](#548))
([99ba5ec](99ba5ec))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.14.6
([#572](#572))
([bed9458](bed9458))
* fixing silent lint failures
([#550](#550))
([30c8022](30c8022))
* nil pointer fix + export constructors
([#555](#555))
([78adb81](78adb81))


### ✨ New Features

* expose Impression metric
([#556](#556))
([77e0a33](77e0a33))
* Introduce kube-proxy-metrics
([#558](#558))
([ad0baeb](ad0baeb))
* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))
([223de99](223de99))
* refactor core module into multiple packages
([#530](#530))
([9d68d0b](9d68d0b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants