This repository was archived by the owner on Sep 30, 2022. It is now read-only.
osc/pt2pt: do no use OPAL_THREAD_ADD64 for lock serial number #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms do no support 64-bit atomic math. osc/pt2pt was using OPAL_THREAD_ADD64 unconditionally which was causing compilation to fail on these platforms. The function in question was alreay grabbing a lock on the osc/pt2pt module so moved the increment to after the lock to protect the module member (instead of using an atomic). Fixes open-mpi/ompi#1162 Signed-off-by: Nathan Hjelm <[email protected]>
|
Test PASSed. |
|
:bot🏷️bug |
|
👍 |
rhc54
pushed a commit
that referenced
this pull request
Mar 15, 2016
osc/pt2pt: do no use OPAL_THREAD_ADD64 for lock serial number
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms do no support 64-bit atomic math. osc/pt2pt was using
OPAL_THREAD_ADD64 unconditionally which was causing compilation to
fail on these platforms. The function in question was alreay grabbing
a lock on the osc/pt2pt module so moved the increment to after the
lock to protect the module member (instead of using an atomic).
Fixes open-mpi/ompi#1162
Signed-off-by: Nathan Hjelm [email protected]