This repository was archived by the owner on Sep 30, 2022. It is now read-only.
libompitrace: explicitly set the .so version #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On master, this value is explicitly set to 0:0:0. On v2.x, set it to 20:0:0 (just so that it is different than master). Fixes open-mpi/ompi#1906. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit open-mpi/ompi@2e0c3c7)
|
Test PASSed. |
|
👍 |
| @@ -41,3 +41,5 @@ libompitrace_la_SOURCES = \ | |||
| request_free.c \ | |||
| send.c \ | |||
| sendrecv.c | |||
|
|
|||
| libompitrace_la_LDFLAGS = -version-info 20:0:0 | |||
There was a problem hiding this comment.
@jsquyres Is there a particular reason why we hard code the 20:0:0 instead of using a variable like $(libompitrace_so_version that would be defined in VERSION?
Seems like this is the only place where we hardcode the version info. All other places reference the VERSION file or something similar.
There was a problem hiding this comment.
That might be a better solution, yes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, this value is explicitly set to 0:0:0. On v2.x, set it to 20:0:0 (just so that it is different than master).
Fixes open-mpi/ompi#1906.
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit open-mpi/ompi@2e0c3c7)
@rhc54 This library was originally created by you 😄 -- can you review?