Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

v1.10: opal.pc.in: fix typo; use the write AC_SUBST'ed variable #950

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented Feb 8, 2016

As reported by @marksantcroos, this substitution in opal.pc was incorrect -- it left @{libdir} in the string (vs. ${libdir}). The fix is simple: use the proper substitution variable in opal.pc (it was never updated to reflect the new/correct name that was created just for the pkg-config files).

Fixes open-mpi/ompi#1343.

(cherry picked from commit open-mpi/ompi@8558def)

@hppritcha or @ggouaillardet please review

As reported by @marksantcroos, this substitution in opal.pc was
incorrect -- it left @{libdir} in the string (vs. ${libdir}).  The fix
is simple: use the proper substitution variable in opal.pc (it was
never updated to reflect the new/correct name that was created just
for the pkg-config files).

Fixes open-mpi/ompi#1343.

(cherry picked from commit open-mpi/ompi@8558def)
@jsquyres jsquyres added the bug label Feb 8, 2016
@jsquyres jsquyres added this to the v1.10.3 milestone Feb 8, 2016
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1319/ for details.

@jsquyres
Copy link
Member Author

jsquyres commented Feb 8, 2016

@hppritcha gave a 👍 on the v2.0.0 version of this PR (#951).

rhc54 pushed a commit that referenced this pull request Feb 9, 2016
v1.10: opal.pc.in: fix typo; use the write AC_SUBST'ed variable
@rhc54 rhc54 merged commit 0f2de88 into open-mpi:v1.10 Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants