This repository was archived by the owner on Sep 30, 2022. It is now read-only.
v1.10: opal.pc.in: fix typo; use the write AC_SUBST'ed variable #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by @marksantcroos, this substitution in opal.pc was incorrect -- it left @{libdir} in the string (vs. ${libdir}). The fix is simple: use the proper substitution variable in opal.pc (it was never updated to reflect the new/correct name that was created just for the pkg-config files). Fixes open-mpi/ompi#1343. (cherry picked from commit open-mpi/ompi@8558def)
|
Test PASSed. |
|
@hppritcha gave a 👍 on the v2.0.0 version of this PR (#951). |
rhc54
pushed a commit
that referenced
this pull request
Feb 9, 2016
v1.10: opal.pc.in: fix typo; use the write AC_SUBST'ed variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @marksantcroos, this substitution in opal.pc was incorrect -- it left @{libdir} in the string (vs. ${libdir}). The fix is simple: use the proper substitution variable in opal.pc (it was never updated to reflect the new/correct name that was created just for the pkg-config files).
Fixes open-mpi/ompi#1343.
(cherry picked from commit open-mpi/ompi@8558def)
@hppritcha or @ggouaillardet please review