Skip to content

rcache/grdma : build broken for CUDA GDR #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjeaugey opened this issue May 24, 2016 · 9 comments
Closed

rcache/grdma : build broken for CUDA GDR #1702

sjeaugey opened this issue May 24, 2016 · 9 comments
Assignees
@hjelmn
Labels
Severity: blocker
Milestone
v2.x

Comments

@sjeaugey
Copy link
Member

As reported by MTT. Build fails at rcache_grdma_module.c:486 ('base' undeclared).
@sjeaugey sjeaugey added this to the Future milestone May 24, 2016
@sjeaugey sjeaugey changed the title Build broken on CUDA GDR rcache/grdma : build broken for CUDA GDR May 24, 2016
hjelmn added a commit to hjelmn/ompi that referenced this issue May 24, 2016
@hjelmn
rcache/grdma: fix typo in cuda code
268dae4 
Fixes open-mpi#1702

Signed-off-by: Nathan Hjelm <[email protected]>
@hjelmn hjelmn mentioned this issue May 24, 2016
Merged
@hjelmn
Copy link
Member

hjelmn commented May 24, 2016

Not in a release so removing blocker flag.

@hjelmn
Copy link
Member

hjelmn commented May 24, 2016

Will be fixed once jenkins finishes on #1703.

@sjeaugey
Copy link
Member Author

Thanks for the fix. I was not sure indeed if flags were relevant outside of releases.

@hjelmn
Copy link
Member

hjelmn commented May 24, 2016

No problem. The flags tend to be used for releases since there is no blocking master :).

@sjeaugey
Copy link
Member Author

👍 I confirm that fixed the build issue. Should be reflected in two days in MTT.

@sjeaugey sjeaugey reopened this May 26, 2016
@sjeaugey sjeaugey modified the milestones: v2.x, Future May 26, 2016
@sjeaugey
Copy link
Member Author

This issue shows up in v2.x now.

@hjelmn
Copy link
Member

hjelmn commented May 26, 2016

Ah yes. Will backport the change.

@rhc54 rhc54 closed this as completed in af52dad May 26, 2016
@sjeaugey sjeaugey reopened this May 26, 2016
@sjeaugey
Copy link
Member Author

Not fixed on v2.x

hjelmn added a commit to hjelmn/ompi-release that referenced this issue May 26, 2016
@hjelmn
rcache/grdma: fix typo in cuda code
6c95223 
Fixes open-mpi/ompi#1702

Signed-off-by: Nathan Hjelm <[email protected]>

(back-port of open-mpi/ompi@af52dad)

Signed-off-by: Nathan Hjelm <[email protected]>
@hjelmn hjelmn mentioned this issue May 26, 2016
Merged
@sjeaugey
Copy link
Member Author

sjeaugey commented Jun 3, 2016

Build is fixed in v2.x.
Closing this one.

@sjeaugey sjeaugey closed this as completed Jun 3, 2016
hjelmn added a commit to hjelmn/ompi that referenced this issue Sep 13, 2016
@hjelmn
rcache/grdma: fix typo in cuda code
d3905b9 
Fixes open-mpi#1702

Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn added a commit to hjelmn/ompi that referenced this issue Sep 21, 2016
@hjelmn
rcache/grdma: fix typo in cuda code
2ee589a 
Fixes open-mpi#1702

Signed-off-by: Nathan Hjelm <[email protected]>
bosilca pushed a commit to bosilca/ompi that referenced this issue Oct 3, 2016
@hjelmn @bosilca
rcache/grdma: fix typo in cuda code
aa9e991 
Fixes open-mpi#1702

Signed-off-by: Nathan Hjelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjelmn hjelmn

Labels
Severity: blocker
Projects
None yet
Milestone
v2.x
Development

No branches or pull requests
2 participants
@hjelmn @sjeaugey