-
Notifications
You must be signed in to change notification settings - Fork 900
Show load errors is defaulting to true #4306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In v2.x and v2.0.x it is default to |
Yeah, this is a sticky issue -- there are definitely valid arguments for setting the default to both True and False. Perhaps the least-worst compromise could be:
This would still seem to give safety to the majority of installations out there (i.e., those who build Open MPI themselves with just the libraries that they want, and want to know immediately if a component fails to load because of a missing library, etc.), but give the downstream packagers (who tend to build Open MPI support with everything that they can) a viable option to not have OMPI bombard users with useless warnings. Thoughts? |
+1 on making the default to False. We can assume that whoever carefully build a minimalistic list of component know what she's doing, so it is not unreasonable to ask her (on the FAQ) to manually set the flag to True. |
@bosilca Keep in mind that building a minimalistic set of components usually just entails "./configure && make -j 32 && make install". I.e., My $0.02 is that it's more unusual to build Open MPI with a maximal set of components. However, this is subjective -- I admittedly have no proof either way. |
I'm not sure when the change occurred, but my point was only that it has changed. I know because I have it set to true in my default MCA param file (in my platform files) precisely because, as a developer, I was running into problems with new components that weren't being loaded. So I unfortunately never saw when it changed. I honestly don't believe the statement that "the majority" of installations are built from scratch - I'm not sure we have any data to support it. I was simply contacted by the OpenHPC folks because they are unexpectedly getting reports of the problem, and it is rather annoying to their users. Perhaps one solution is to make it true by default on debug builds, and false otherwise? It is, after all, a debug output. |
@jsquyres even for modules depending on particular hardware this is not always the case (libraries and headers are sometimes available). For modules no depending on hardware, they are all compiled despite the fact that most of them will never be used - due to their default priority that almost nobody cares to change. I would love to see some statistics about this ... but is outside the scope of the current discussion. |
Let's discuss on Tuesday. |
We are in the 'build the maximal set of components' camp - which is possibly rare. We have to explicitly set this value to I think discussing this default is a good idea. Setting it to |
The telecon today left this with the feeling that we should at least create a new configure option for setting the default value. There was some discussion as to the proper default for that option - one suggestion (that at least two of us favored) was to set it true for debug builds, but false for non-debug builds. No definitive decision was made. |
Completed |
In v3.x, and on master, the default value for the MCA param "mca_base_component_show_load_errors" is being set to "true". This means that people who install OMPI from a packager get load errors reported for every component whose library isn't installed.
IIRC, our policy was to default this to "false" for just that reason. Did someone change it by mistake?
The text was updated successfully, but these errors were encountered: