configure: add --en|disable-show-load-errors-by-default #4330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give packagers a configure CLI option to set the value of the MCA variable mca_base_component_show_load_errors. The --disable form of this option is intended for Open MPI packagers who tend to enable support for many different types of networks and systems in their packages. For example, consider a packager who includes support for both the FOO and BAR networks in their Open MPI package, both of which require support libraries (libFOO.so and libBAR.so). If an end user only has BAR hardware, they likely only have libBAR.so available on their systems -- not libFOO.so. Disabling load errors by default will prevent the user from seeing potentially confusing warnings about the FOO components failing to load because libFOO.so is not available on their systems. Conversely, system administrators tend to build an Open MPI that is targeted at their specific environment, and contains few (if any) components that are not needed. In such cases, they might want their users to be warned that the FOO network components failed to load (e.g., if libFOO.so was mistakenly unavailable), because Open MPI may otherwise silently failover to a slower network path for MPI traffic. Signed-off-by: Jeff Squyres <[email protected]>
gpaulsen
approved these changes
Oct 12, 2017
rhc54
approved these changes
Oct 12, 2017
|
I'm going to go ahead and merge this so that we can make forward progress on the issue, and start bringing it to whatever release branches we choose (v3.0.x and v3.1.x?). I left the default alone -- it's still enabled by default. But I agree: we can continue the conversation that if we choose to change the default, that can be a follow-on commit+PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give packagers a configure CLI option to set the value of the MCA variable
mca_base_component_show_load_errors.The
--disableform of this option is intended for Open MPI packagers who tend to enable support for many different types of networks and systems in their packages. For example, consider a packager who includes support for both the FOO and BAR networks in their Open MPI package, both of which require support libraries (libFOO.soandlibBAR.so). If an end user only has BAR hardware, they likely only havelibBAR.soavailable on their systems -- notlibFOO.so. Disabling load errors by default will prevent the user from seeing potentially confusing warnings about the FOO components failing to load becauselibFOO.sois not available on their systems.Conversely, system administrators tend to build an Open MPI that is targeted at their specific environment, and contains few (if any) components that are not needed. In such cases, they might want their users to be warned that the FOO network components failed to load (e.g., if
libFOO.sowas mistakenly unavailable), because Open MPI may otherwise silently failover to a slower network path for MPI traffic.Signed-off-by: Jeff Squyres [email protected]
I'm labeling this as both a bug and an enhancement. Technically, it's an enhancement (because it's a new feature), but it enables functionality that prevents downstream packagers from having to patch Open MPI. So from that perspective, you could consider it a bug.
And if we consider it a bug, we should probably consider bringing this to all release branches (or perhaps at least to v3.0.x and v3.1.x).
Refs #4306