Skip to content

Fortran MPI_FILE_GET_POSITION bug #6858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wkliao opened this issue Aug 1, 2019 · 8 comments
Closed

Fortran MPI_FILE_GET_POSITION bug #6858

wkliao opened this issue Aug 1, 2019 · 8 comments

Comments

@wkliao
Copy link
Contributor

wkliao commented Aug 1, 2019

Fortran test program ompi/mca/io/romio321/romio/test/fmisc.f.in
fails when calling MPI function MPI_FILE_GET_POSITION.

I tested it with the master branch and 4.0.1 release, both built with romio and without romio.
Note the Fortran file is created after running configure and available in BUILD_DIR/ompi/mca/io/romio321/romio/test/fmisc.f

The same test program passes when compiled with MPICH.
I checked MPI standard about the function MPI_FILE_GET_POSITION and
the value returned by MPICH is correct.

@edgargabriel edgargabriel self-assigned this Aug 1, 2019
@edgargabriel
Copy link
Member

Thanks for the bug report, I will look into it.

edgargabriel added a commit to edgargabriel/ompi that referenced this issue Aug 5, 2019
and SEEK_CUR. fixes an issue reported by Wei-keng Liao

Fixes Issue open-mpi#6858

Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Aug 16, 2019
and SEEK_CUR. fixes an issue reported by Wei-keng Liao

Fixes Issue open-mpi#6858

Signed-off-by: Edgar Gabriel <[email protected]>
@gpaulsen
Copy link
Member

gpaulsen commented Sep 2, 2019

@edgargabriel Can we close this issue now?

@edgargabriel
Copy link
Member

Sorry for my silence on this. I could make create a patch for 3.1, the bug is also in the 3.0.x and 3.1.x series, it is really a question to the release managers whether they would like to have that fix.

@jsquyres
Copy link
Member

jsquyres commented Sep 3, 2019

@edgargabriel How big of a fix is this?

@edgargabriel
Copy link
Member

@jsquyres the fix itself is very localized to one file, and only really affects a special case (fixing the calculations for moving the file pointer to the end of the file in the case where the actual end of the file offset is however not part of your file view).

@jsquyres
Copy link
Member

jsquyres commented Sep 3, 2019

If it's nice and small like this, and you don't mind, we'd take fixes like this for v3.0.x and v3.1.x. 👍

@edgargabriel
Copy link
Member

ok, will do, give me a day or two for creating the pr's

edgargabriel added a commit to edgargabriel/ompi that referenced this issue Sep 4, 2019
and SEEK_CUR. fixes an issue reported by Wei-keng Liao

Fixes Issue open-mpi#6858

Note, that some manual adjustements were required compared to the commit
on master due to structural differences in ompio between master and 3.x
branches.

(cherry picked from commit 34b06dc)
Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Sep 4, 2019
and SEEK_CUR. fixes an issue reported by Wei-keng Liao

Fixes Issue open-mpi#6858

Note, that some manual adjustements were required compared to the commit
on master due to structural differences in ompio between master and 3.x
branches.

(cherry picked from commit 34b06dc)
Signed-off-by: Edgar Gabriel <[email protected]>
@gpaulsen
Copy link
Member

gpaulsen commented Apr 9, 2021

I think has been resolved on all release branches. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants