Fix leak of sm_segment files in /dev/shm. #10040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that there were dozens of 'sm_segment.$HOSTNAME.$UID..' files leftover in /dev/shm. This seems to clean it up - the correct namespace wasn't being added so the cleanup callback was doing nothing. This may also cleanup some other leaks, as opal_pmix_register_cleanup() is used in open_file() in opal/util. Signed-off-by: Austen Lauria <[email protected]>
awlauria
force-pushed
the
fix_shm_file_leak
branch
from
5dc6324 to
7412e27
Compare
gpaulsen
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there were dozens of 'sm_segment.$HOSTNAME.$UID..'
files leftover in /dev/shm. This seems to clean it up - the
correct namespace wasn't being added so the cleanup callback
was doing nothing.
This may also cleanup some other leaks, as opal_pmix_register_cleanup()
is used in open_file() in opal/util.
Signed-off-by: Austen Lauria [email protected]