Minor docs updates #10213
Merged
Minor docs updates #10213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
approved these changes
Apr 4, 2022
Signed-off-by: Jeff Squyres <[email protected]>
Be foreward looking and use the "new" dependency resolver. This also fixes a dependency issue with docutils in some environments (e.g., Fedora 33). Signed-off-by: Jeff Squyres <[email protected]>
citutor.org is now hpc-training.org. Signed-off-by: Jeff Squyres <[email protected]>
HTML docs are installed in $(docdir)/html. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/yet-more-docs
branch
from
1c47353 to
1c0e7e7
Compare
|
Once CI finishes, I'll merge so that we can rebase #10224 on top of this (because this PR now installs the HTML docs, which affects the RPM specfile). |
|
bot:aws:retest |
1 similar comment
|
bot:aws:retest |
jsquyres
force-pushed
the
pr/yet-more-docs
branch
from
1c0e7e7 to
8ffe33f
Compare
|
Added 2 lines to the
|
bwbarrett
reviewed
Apr 9, 2022
| install-data-hook: | ||
| $(MKDIR_P) $(DESTDIR)$(docdir) | ||
| cp -r $(srcdir)/_build/html $(DESTDIR)$(docdir) | ||
| find $(DESTDIR)$(docdir) -type d -exec chmod 0755 {} \; |
There was a problem hiding this comment.
First, there needs to be a comment about this behavior, because the history will be lost on why we're chmodding if the only place the history exists is a comment in the PR.
Second, I don't think this is actually Automake's behavior. I agree AM installs files as 0644, but it appears that there's more logic around setting directory permissions, which I haven't entirely pulled apart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pip's
--use-feature=2020-resolverto fix a dependency problem in some environments (e.g., Fedora 33).