osc/ucx: flush all the outstanding transfers before cleaning up the thread local context #10238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hread local context Signed-off-by: Mamzi Bayatpour <[email protected]> Co-authored-by: Tomislav Janjusic <[email protected]>
|
bot:aws:retest |
janjust
approved these changes
Apr 8, 2022
gpaulsen
suggested changes
Apr 8, 2022
| winfo->global_inflight_ops = 0; | ||
| memset(winfo->inflight_ops, 0, winfo->comm_size * sizeof(short)); | ||
| opal_mutex_unlock(&winfo->mutex); | ||
| if (rc != OPAL_SUCCESS) { |
There was a problem hiding this comment.
It'd be better to move the check for failure inside of the mutex (but of course remember to unloc before returning).
There was a problem hiding this comment.
rc is a local variable, so it is immune to being changed by another thread for what it is worth.
There was a problem hiding this comment.
yea I was going to ask - why move it inside the mutex?
awlauria
approved these changes
Apr 8, 2022
gpaulsen
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.