Attributes: replace custom void* union with C union [v5.0.x] #10353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation uses a void* to store different types of attribute value integers and attempts to figure out proper offsets for storing smaller integers in that pointer. The required pointer aliasing is UB and causes issues with GCC 11. The new implementation replaces the self-built pointer-based union with a C union and selects the (pointer to the) right field based on the av_set_from value. This patch also fixes a bug where copied attributes always had the set_from field set to C pointer, which worked but is technically not correct. Signed-off-by: Joseph Schuchart <[email protected]> (cherry picked from commit fdc7108)
Correct a few minor mistakes in the large comment at the top of ompi/attribute/attribute.c from when 72cfbb6 added several new cases to attribute handling. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit cce89e8)
jsquyres
approved these changes
May 4, 2022
|
Good point, PR for 4.1.x is at #10357. Do we still backport to 4.0.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses a void* to store different types of attribute value integers and attempts to figure out proper offsets for storing smaller integers in that pointer. The required pointer aliasing is UB and causes issues with GCC 11.
The new implementation replaces the self-built pointer-based union with a C union and selects the right field based on the av_set_from value.
This patch also fixes a bug where copied attributes always had the set_from field set to C pointer, which worked but is technically not correct.
Backport of #10344 to v5.0.x
Related #10339
Signed-off-by: Joseph Schuchart [email protected]