threads: configury updates for argo and qthreads #10646
Conversation
|
We're using OAC_CHECK_PACKAGE in other locations as well. Are those use-cases not affected? |
|
@janciesko we're doing something a little unusual in the argo/qthreads config/makefile so probably other components weren't impacted. |
hppritcha
force-pushed
the
fix_item_one_of_issue10459
branch
from
2977d7b to
e5a50e4
Compare
|
I updated the changes with some text about what's going on here. |
| dnl extract the fully qualified include path from the opal_argo_CPPFLAGS variable | ||
| dnl for use in threads_argobots.h | ||
| AS_IF([test $opal_argo_happy = yes && test $opal_argo11_happy = yes], | ||
| [OPAL_ARGO_INCLUDE_PATH=`echo "${opal_argo_CPPFLAGS}/" | sed -e 's/\-I//g' | sed -e 's/ //g'`], |
There was a problem hiding this comment.
This has an implicit assumption that opal_argo_CPPFLAGS only contains 1 directory, which may be true today but doesn't seem long term true.
But why are we doing this at all? It looks like we're doing it to because we need to include abt.h in a header that then is included in opal/mca/threads/threads.h. I think we'd be better off skipping this bit (that doesn't do what we test) and just adding opal_argo_CPPFLAGS into CPPFLAGS.
Accomodate changes from going from OPAL_CHECK_PACKAGET to OAC_CHECK_PACKAGE. related to open-mpi#10459 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
fix_item_one_of_issue10459
branch
from
e5a50e4 to
ef38d92
Compare
|
@janciesko i reworked things per @bwbarrett suggestions. please check that this works for you now. |
The OAC_CHECK_PACKAGE macro doesn't have quite the same
functionality as the origina ?OPAL_CHECK_PACKAGE? macro,
so add some sed magic to get the path we need for
argo/qthread related header files.
related to #10459
Signed-off-by: Howard Pritchard [email protected]