v5: MPI 4: Add MPI_COMM_TYPE_HW_UNGUIDED and MPI_COMM_TYPE_HW_GUIDED #10703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhursey
changed the title
|
This cherry-picks:
|
jjhursey
force-pushed
the
v5-hw-guided
branch
2 times, most recently
from
16e410d to
9b95f39
Compare
|
The |
|
FYI: I just pushed on a missing help message PR #10778 from |
* `MPI_COMM_TYPE_HW_GUIDED` supports all of the existing `OMPI_COMM_TYPE_` options. * `MPI_COMM_TYPE_HW_UNGUIDED` is recognized, but not supported so it returns `MPI_COMM_NULL` indidicating that the MPI library cannot split the communicator any further. Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 19e24fa)
* The wrong split type was being passed to the `ompi_comm_split_type_get_part` function. It was passing the "original" (`MPI_COMM_TYPE_HW_GUIDED`) split type and not the "converted" (e.g., `MPI_COMM_TYPE_SHARED`) split type. This resulted in an error indicating that the split type was invalid. Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 6f1c128)
Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 349cb75)
Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 6ddcc58)
Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 2b70dcc)
jjhursey
force-pushed
the
v5-hw-guided
branch
from
8aa2c87 to
951b362
Compare
awlauria
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.