[4.1.x] GCC atomics: acquire thread-fence was busted until GCC 8.1.0 #10723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Schuchart <[email protected]> (cherry picked from commit e72273a)
devreal
changed the title
bwbarrett
approved these changes
Aug 26, 2022
|
@devreal Why only a partial cherry-pick? |
|
@gpaulsen In 4.1.x, an atomic variable was a structure so the missing part of that cherry-pick does not apply. The initialization was correct in 4.1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC's acquire thread-fence was busted until GCC 8.1.0 (similar for C11). Check godbolt for an example compiled with GCC 7 and 8. Notice that the load of x is optimized out of the loop when compiling with GCC 7. We had previously updated the version of the busted GCC for the C11 atomics (#10118).
Partial cherry-pick of #10721 to 4.1.x.