Skip to content

Implement MPI_COMM_TYPE_HW_UNGUIDED for MPI_Comm_split_type for MPI 4 #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

Implement MPI_COMM_TYPE_HW_UNGUIDED for MPI_Comm_split_type for MPI 4 #10739

merged 1 commit into from
Oct 10, 2022

Conversation

drwootton
Copy link
Contributor

Implement MPI_COMM_TYPE_HW_UNGUIDED for MPI_Comm_split_type as specified in the MPI 4.0 standard section 7.4

Signed-off-by: David Wootton [email protected]

@drwootton drwootton requested a review from jjhursey August 31, 2022 21:19
@drwootton drwootton self-assigned this Aug 31, 2022
@jjhursey jjhursey mentioned this pull request Sep 1, 2022
Merged
jjhursey
jjhursey suggested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes of refactoring to fit it under the parameter checking that's part of the ompi_comm_split_type function.

Outside of that, it looks good. Thanks!

@jjhursey jjhursey linked an issue Sep 6, 2022 that may be closed by this pull request
MPI 4: Improve implementation of MPI_COMM_TYPE_HW_UNGUIDED #10635
Closed
jjhursey
jjhursey suggested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some MPI_UNDEFINED tests to the ompi-tests-public test case for the UNGUIDED case. I think some cases need to be exercised.

@drwootton drwootton requested a review from bosilca September 19, 2022 18:23
@drwootton
Copy link
Contributor Author

Review comments are resolved with help from @jjhursey. @jjhursey asked that i add @bosilca as reviewer for these changes.

@gpaulsen gpaulsen requested review from jjhursey and removed request for jjhursey September 19, 2022 19:12
@gpaulsen
Copy link
Member

@jjhursey is out a while, but no way to remove him from Review Request.

@gpaulsen
Copy link
Member

New test for this case added here: open-mpi/ompi-tests-public#23

@gpaulsen gpaulsen mentioned this pull request Sep 19, 2022
Merged
@drwootton drwootton removed the request for review from jjhursey September 20, 2022 16:44
@bwbarrett
Copy link
Member

bot:aws:retest

bosilca
bosilca reviewed Sep 29, 2022
View reviewed changes
@drwootton drwootton requested a review from bosilca October 3, 2022 18:28
bosilca
bosilca approved these changes Oct 3, 2022
View reviewed changes
ompi/communicator/comm.c Outdated

/* Set name for debugging purposes */
snprintf(newcomp->c_name, MPI_MAX_OBJECT_NAME, "MPI COMM %s SPLIT_TYPE FROM %s",
ompi_comm_print_cid (newcomp), ompi_comm_print_cid (comm));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix indentation.

Implement MPI_COMM_TYPE_HW_UNGUIDED for MPI_Comm_split_type
991fab3 
Fix review comments

Signed-off-by: David Wootton <[email protected]>
@jjhursey
Copy link
Member

bot:aws:retest

@jjhursey jjhursey merged commit a6522fd into open-mpi:main Oct 10, 2022
@jjhursey
Copy link
Member

Please PR to v5.0.x. Thanks!

@drwootton drwootton mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosilca bosilca bosilca approved these changes

@jjhursey jjhursey jjhursey approved these changes

Assignees

@drwootton drwootton

Labels
Target: main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPI 4: Improve implementation of MPI_COMM_TYPE_HW_UNGUIDED
5 participants
@drwootton @gpaulsen @bwbarrett @jjhursey @bosilca