opal/accelerator: Remove function table and dlopen logic #10857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alongside this, I want to add link libcuda against the gpusm, rgpusm, and smcuda components and directly call cuda functions within them. |
wckzhang
force-pushed
the
removefunc
branch
from
8d4e505 to
5f45e6c
Compare
bwbarrett
requested changes
Sep 27, 2022
|
Overall, nice job on a big AC change. Couple of minor things and you should be good to go. |
wckzhang
force-pushed
the
removefunc
branch
from
5f45e6c to
f23e8f9
Compare
wckzhang
force-pushed
the
removefunc
branch
from
f23e8f9 to
ce27375
Compare
bwbarrett
approved these changes
Sep 27, 2022
|
bot:aws:retest |
|
I'm also going to add the code that replaces opal/cuda and remove opal/cuda in this PR |
wckzhang
force-pushed
the
removefunc
branch
from
219fe1f to
8cb9c97
Compare
|
bot:aws:retest |
|
Real failure when I added the opal_cuda.h header, need to figure out what I did wrong |
Instead of dlopening cuda, add direct dependency on libcuda. This also means we can remove the dlopen dependency. Signed-off-by: William Zhang <[email protected]>
Signed-off-by: William Zhang <[email protected]>
wckzhang
force-pushed
the
removefunc
branch
from
8cb9c97 to
a560402
Compare
|
Ah I forgot to add the opal_cuda.h file to git, should work now |
|
bot:aws:retest |
Signed-off-by: William Zhang <[email protected]>
wckzhang
force-pushed
the
removefunc
branch
from
a560402 to
d5ba0a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of dlopening cuda, add direct dependency on libcuda. This also means we can remove the dlopen dependency.
Signed-off-by: William Zhang [email protected]