Initialize opal/smsc outside of btl/sm, to enable its use without it #10897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Katevenis <[email protected]>
|
Can one of the admins verify this patch? |
|
Please bring back to v5.0.x |
bwbarrett
reviewed
Oct 12, 2022
| @@ -498,6 +498,10 @@ static int ompi_mpi_instance_init_common (int argc, char **argv) | |||
|
|
|||
| /* Select which MPI components to use */ | |||
|
|
|||
| if (OPAL_SUCCESS != (ret = mca_smsc_base_select())) { | |||
| return ompi_instance_print_error ("mca_smsc_base_select() failed", ret); | |||
There was a problem hiding this comment.
Previously, OMPI would silently handle smsc not being initialized. Now it's printing a warning. That does not seem like the behavior we want?
There was a problem hiding this comment.
At the moment mca_smsc_base_select() only returns OPAL_SUCCESS. The actual smsc components might still remain silently uninitialized. My though process here is that if it at some point in the future mca_smsc_base_select() started possibly returning something else, it would be something severe enough to warrant triggering an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this places the initialization call for opal/smsc in an allegedly (more) appropriate place -- I'm accepting input about the "legality" of its placement :-). Currently, the call is placed inside btl/sm, but if it is not loaded (e.g. because pml=ucx), smsc will remain uninitialized. My initial thought was that a component requiring smsc could initialize it on demand as necessary, but this might be too late for the modex to be properly sent/commited. For example, this occurs with collectives components that utilize smsc (#10342).
Fixes #10342
Signed-off-by: George Katevenis [email protected]