add sha256 generation func to opal util toolbox #11031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like there may be at least one place in ompi where being able to compute a sha of a user supplied string plus internally generated data could be useful, so add function to do this to the opal util toolbox. Related to open-mpi#10895 This code is derived from a sha256 implementation at https://github.com/B-Con/crypto-algorithms.git Signed-off-by: Howard Pritchard <[email protected]>
jjhursey
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
I see how this could be useful for generating signatures for session/group handles.
The license described in the README.md in the latest version allows (from my reading) us to pull it into Open MPI without further burden on the community.
|
@hppritcha did you want this in v5.0.x? |
|
yes i will open a PR tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there may be at least one place in ompi where being able to compute a sha of a user supplied string plus internally generated data could be useful, so add function to do this to the opal util toolbox.
Related to #10895
This code is derived from a sha256 implementation at
https://github.com/B-Con/crypto-algorithms.git
Signed-off-by: Howard Pritchard [email protected]