Skip to content

add sha256 generation func to opal util toolbox #11031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

hppritcha
Copy link
Member

Looks like there may be at least one place in ompi where being able to compute a sha of a user supplied string plus internally generated data could be useful, so add function to do this to the opal util toolbox.

Related to #10895

This code is derived from a sha256 implementation at

https://github.com/B-Con/crypto-algorithms.git

Signed-off-by: Howard Pritchard [email protected]

Looks like there may be at least one place in ompi where being able to
compute a sha of a user supplied string plus internally generated
data could be useful, so add function to do this to the opal util
toolbox.

Related to open-mpi#10895

This code is derived from a sha256 implementation at

https://github.com/B-Con/crypto-algorithms.git

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha requested a review from hjelmn November 3, 2022 19:25
@hppritcha hppritcha requested review from jjhursey and removed request for hjelmn November 3, 2022 19:26
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how this could be useful for generating signatures for session/group handles.

The license described in the README.md in the latest version allows (from my reading) us to pull it into Open MPI without further burden on the community.

@hppritcha hppritcha merged commit ff62b05 into open-mpi:main Nov 4, 2022
@awlauria
Copy link
Contributor

@hppritcha did you want this in v5.0.x?

@hppritcha
Copy link
Member Author

yes i will open a PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants