io/romio341: fix support for GCC 4.8 compilers #11089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
approved these changes
Nov 18, 2022
|
Minor: I'd actually call this a bug, not an enhancement. It should definitely be PR'ed to v5.0.x. |
bwbarrett
approved these changes
Nov 18, 2022
ggouaillardet
force-pushed
the
topic/romio341_gcc48
branch
from
529e52c to
802e2b2
Compare
|
thanks @bwbarrett for your comment. I reviewed the patch and found a case was simply ignored, so I updated the fix. @jsquyres can you please give it an other review? |
jsquyres
requested changes
Nov 21, 2022
jsquyres
reviewed
Nov 21, 2022
ggouaillardet
force-pushed
the
topic/romio341_gcc48
branch
from
802e2b2 to
e670095
Compare
|
@jsquyres I made the suggested changes |
jsquyres
approved these changes
Nov 21, 2022
Thanks! |
ROMIO 3.4.1 requires <stdatomic.h>, but this is not checked by the embedded configure, causing a failure at compilation time if the compiler (such as GCC 4.8 provided by RHEL7 like distros). Explicitly check for <stdatomic.h> and disable the io/romio341 component and the third party ROMIO if not available. Refs. open-mpi#11088 Signed-off-by: Gilles Gouaillardet <[email protected]>
ggouaillardet
force-pushed
the
topic/romio341_gcc48
branch
from
e670095 to
c2ac975
Compare
bwbarrett
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROMIO 3.4.1 requires <stdatomic.h>, but this is not checked by the embedded configure, causing a failure at compilation time if the compiler (such as GCC 4.8 provided by RHEL7 like distros).
Explicitly check for <stdatomic.h> and disable the io/romio341 component and the third party ROMIO if not available.
Refs. #11088
Signed-off-by: Gilles Gouaillardet [email protected]