osc/ucx: Fix bugs with dynamic windows #11095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: f988411: Remove unnecessary (and incorrect) dynamic window ...
23ea49c: Add missing dynamic_lock member in ompi_osc_ucx_st...
d5cc3ba: Correctly return error codes in get_dynamic_win_in...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
Signed-off-by: Shumpei Shiina <[email protected]>
Signed-off-by: Shumpei Shiina <[email protected]>
Signed-off-by: Shumpei Shiina <[email protected]>
s417-lama
force-pushed
the
fix_dynamic_window
branch
from
f988411 to
cd40003
Compare
|
Sorry to mess it up. I added |
|
ok to test |
|
FYI @open-mpi/ucx team |
devreal
approved these changes
Nov 21, 2022
janjust
approved these changes
Nov 24, 2022
|
@s417-lama cam you please open up the v5.0 of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three small bug fixes for dynamic windows in osc/ucx.
The first two fixes are for bugs introduced in this PR #10709 :
get_dynamic_win_info()function always returnedOMPI_SUCCESSeven if it caused an error in the middle, which hid the next error belowOSC_UCX_STATE_DYNAMIC_LOCK_OFFSETwas introduced but no actualdynamic_lockmember was added, which resulted in corrupteddynamic_win_countvalueThe third issue is independent of the above PR, but it causes an error when we call
MPI_RgetorMPI_Rputfor dynamic windows.As the
remote_addrvalue for rget/rput was wrong, the dynamic window check always failed with rget/rput.I fixed this issue by simply removing dynamic window check for rget/rput, because the request is eventually forwarded to
ompi_osc_ucx_get/put, which correctly checks dynamic window status anyway.