Skip to content

Fix uninitialized pointer in mca_smpl_ucx_register: Coverity CID 1498717 #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix uninitialized pointer in mca_smpl_ucx_register: Coverity CID 1498717 #11208

merged 1 commit into from
Dec 16, 2022

Conversation

drwootton
Copy link
Contributor

Coverity static analysis reports use of an uninitialized pointer at label error_unmap in mca_smpl_ucx_register

Fixes are to initialize ucx_mkey to NULL, to chance the error branch at line 743 to jump to error_out since ucx_mkey has not been set at this point, and check that ucx_mkey is not null before calling ucp_mem_unmap.
Signed-off-by: David Wootton [email protected]

Coverity CID 1498717

Signed-off-by: David Wootton <[email protected]>
@drwootton drwootton requested a review from brminich December 13, 2022 18:11
@drwootton drwootton self-assigned this Dec 13, 2022
@janjust
Copy link
Contributor

janjust commented Dec 15, 2022

bot:retest

@janjust janjust merged commit 5bbc591 into open-mpi:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants