remove redundant PMIx fence calls at initialization #11212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhc54
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
That does indeed remove the duplication - whether the code belongs here or there is beyond my knowledge. However, this should get rid of the extra "fence" calls.
Thanks @hppritcha !
|
curious about the fortran test failures, rerun. |
|
bot:ompi:retest |
related to issue open-mpi#11166 Turns out making these changes revealed some issues with the way MPI_Session_init is implemented. Unless async modex and disabling of collective info is turned on, the path through MPI initialization for Sessions isn't really local. The code in ompi_mpi_instance_init_common will eventually need to be refactored to move synchronizing elements up into ompi_mpi_init for the world process model and into some delayed-till- comm creation routine(s) when using the sessions process model. also, remove a second wait on a debugger. We should only do this once. At some point a solution for attaching a debugger to an application which only uses the sessions process model will need to implemented. Given the semantics of sessions, its not clear when is the right point to synchronize processes with a debugger. Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
fix_for_11166_v2
branch
from
cd7e1d0 to
c4adbb9
Compare
|
closing this PR and will open a fresh one with a simpler approach to address issue #11166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #11166
Turns out making these changes revealed some issues with the way MPI_Session_init is implemented. Unless async modex and disabling of collective info is turned on, the path through MPI initialization for Sessions isn't really local. The code in ompi_mpi_instance_init_common will eventually need to be refactored to move synchronizing elements up into ompi_mpi_init for the world process model and into some delayed-till- comm creation routine(s) when using the sessions process model.
also, remove a second wait on a debugger. We should only do this once. At some point a solution for attaching a debugger to an application which only uses the sessions process model will need to implemented. Given the semantics of sessions, its not clear when is the right point to synchronize processes with a debugger.
Signed-off-by: Howard Pritchard [email protected]