v5.0: Fix singleton operations #11227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You cannot daemonize the "prte" executable when spawning it to support a singleton as that will cause things to hang. Also fix IO forwarding thru the singleton for the spawned child procs by correcting a mistake that caused the IOF request attributes to be overlooked when constructing the job info for the PMIx_Spawn call. Includes an update to the PMIx and PRRTE submodule pointers to pickup a couple of relevant corrections there. See: openpmix/prrte#1621 openpmix/openpmix#2881 This brings the submodule pointers to the HEAD of their respective release branches, which are basically at an rc1 level (but not tagged yet). Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 8ca4d7c)
jsquyres
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot daemonize the "prte" executable when spawning it to support a singleton as that will cause things to hang. Also fix IO forwarding thru the singleton for the spawned child procs by correcting a mistake that caused the IOF request attributes to be overlooked when constructing the job info for the PMIx_Spawn call.
Includes an update to the PMIx and PRRTE submodule pointers to pickup a couple of relevant corrections there. See:
openpmix/prrte#1621
openpmix/openpmix#2881
This brings the submodule pointers to the HEAD of their respective release branches, which are basically at an rc1 level (but not tagged yet).
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 8ca4d7c)