v5.0.x: pml/ucx: move pmix finalize to the end of ompi_rte_finalize() #11263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamzi Bayatpour <[email protected]> (cherry picked from commit a12aa2f)
|
Adding the label WIP until we discuss the issues raised in RM channel |
janjust
approved these changes
Jan 10, 2023
|
This change brought up several discussions that we need to address, I'll merge for now since this does fix a severe Finalize bug to keep consistent with main branch, and any subsequent changes will be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5.0.x: pml/ucx: move pmix finalize to the end of ompi_rte_finalize()
Signed-off-by: Mamzi Bayatpour [email protected]
(cherry picked from commit a12aa2f)