coll/han: call fallback functin when HAN module is disabled #11454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is to address:
open-mpi#11448
When Open MPI is compiled with CUDA support,
comm->c_coll->coll_xxx_module is coll_cuda_module and
HAN_LOAD_FALLBACK_COLLECTIVE is a no-op.
As a result, HAN's collective functions can be called
even if HAN has been disabled, which resulted an infinitely
recursive calling loop.
To address this issue, this patch make HAN's collective
fucntion to call fallback function when HAN module was
disabled.
Signed-off-by: Wei Zhang <[email protected]>
|
@bosilca Can you review? |
bosilca
approved these changes
Mar 8, 2023
bosilca
force-pushed
the
coll_han_fix_infinite_loop
branch
from
ad645fc to
8345dae
Compare
Instead of calling the communicator collective module after disqualifying HAN call directly the fallback collective. This avoids circular dependencies between modules in some cases. However, while this solution works it deliver suboptimal performance as the withdrawn module will remain in the call chain, but will behave as a passthrough. Signed-off-by: George Bosilca <[email protected]>
bosilca
force-pushed
the
coll_han_fix_infinite_loop
branch
from
8345dae to
00de8b7
Compare
|
I can confirm it fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to address:
#11448
When Open MPI is compiled with CUDA support,
comm->c_coll->coll_xxx_module is coll_cuda_module and HAN_LOAD_FALLBACK_COLLECTIVE is a no-op.
As a result, HAN's collective functions can be called even if HAN has been disabled, which resulted an infinitely recursive calling loop.
To address this issue, this patch make HAN's collective fucntion to call fallback function when HAN module was disabled.