Use acquire/release barrier to synchronize completion of request and test/wait #11665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test/wait Before completing the request we should make sure that all other pieces are visible, the status. The release barrier should synchronize with an acquire barrier before reading the status in test/wait. This also removes a full memory barrier at the beginning of test functions that does not seem to serve any purpose. Signed-off-by: Joseph Schuchart <[email protected]>
bosilca
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before completing the request we should make sure that all other pieces are visible, i.e., the status. The release barrier should synchronize with an acquire barrier before reading the status in test/wait to ensure that status is current.
This also removes a full memory barrier at the beginning of test functions that does not seem to serve any purpose.
Thanks to @joerowell for the report.
Fixes #11652